Skip to content
Submitted over 3 years ago

fylo-data-storage-component-master

Mojtaba Mosavi•3,760
@MojtabaMosavi
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Fylo data storage component
  • HTML
  • CSS
2junior

Design comparison

SolutionDesign

Solution retrospective

Any feedback appreciated in general and specially regarding the following qestions.

  1. What is you though process when you create mixins ?
  2. Have I done good job following the mobile first workdflow ?
  3. Would write the markup the same way, if not what would do differently(I pleased if you also explain why) ?

Happy coding ?

Community feedback

  • Luis Colina•1,043
    @Comet466Posted over 3 years ago

    hi Mojtaba, good work on this challenge it looks really close to the intended design, just wanted to point out a few details that you might had miss

    1. the mobile background has this black sport between 846px and 346px width that damage the presentation of the layout 2.the icons of the package container are not align, you could fix this just by adding a display:flex;align-items:center to the icons container 3.triangle of the floater looks a little off

    happy coding!

    1
    Mojtaba Mosavi•3,760
    @MojtabaMosaviPosted over 3 years ago

    @Comet466 you have great eye for details, quite easy to miss, next time I'll make sure I do a double check before submit the solution. About the black spot, I would be thankful if you mention it's specific position.

    Happy coding :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord