Fylo landing with scss, grid, cool hover/focus effects

Community feedback

• 

  Shashi Lo•1,345

  @shashiloPosted over 4 years ago

  Another great job Roman. The nav link CSS transitions are really cool and the mobile implementation is awesome. I did find some things that can be improved:

  • The style guide calls for the max-width for desktop to be 1440px. Yours is set at 1170px. This causes the site to look thinner and the columns to not match the design.
  • All of your headings are using the wrong font. They should be using var(--ff-heading) instead of var(--ff-body)
  • The Stay productive, wherever you are seems to be incomplete on desktop. The heading is small and not vertically aligned to the section.
  • The Get early access today CTA container is too thin. It causes the content to feel squished in, but it also doesn't match the design specs.
  • I like the sticky header, but the transition is wonky. It looks like it's growing then shrinking. When you scroll back up and the sticky header is removed, it jumps a few times before it's removed. I would like to see this get smoothened out.
  • Fixing the button :hover transition would be nice too. A nice smooth gradient transition would make this implementation even better.

  2

  ---

  

  Roman Filenko•3,335

  @rfilenkoPosted over 4 years ago

  @shashilo hi Shashi, appreciate your feedback, will work on those to polish this up😉

  1
• 

  Nasratullah Talash•255

  @nasrattPosted over 4 years ago

  I can only say WOW WOW, man; keep it up. Any points to learn animations on JS?

  0

  ---

  

  Roman Filenko•3,335

  @rfilenkoPosted over 4 years ago

  @NasratTalash thanks, generally it's better to make animations via css, they are more performant and quite functional

  0