Fylo landing updage, SCSS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋Hi Rabah!

  I have some feedback on this solution:

  • The nav links should have a very dark blue color.
  • Try to add simple form validation using :invalid.
  • The content should be on its own section, not within the header.
  • The footer logo should be white. You can have a white logo by opening the logo.svg and copy everything. Then you create a new file logo-white.svg and paste in. Lastly you can change all the fill="#fff".
  • The All your files... should be h1.
  • For the logo image, the alt attribute should contain the company name Fylo not the logo word.

  That's it! Hopefully this is helpful!

  Marked as helpful

  1

  ---

  

  Rabah•380

  @rabahmilanoPosted over 3 years ago

  @vanzasetia Thank you very much for your time Vanza ! Your feedbacks was very helpful, I fixed some design issues, but I steel some difficulties in the organization of the SCSS files since it is my first try with this preprocessor.

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  @rabahmilano You can try the 7 - 1 Pattern to help organize Sass files. Here is a Sass Guidelines that will explain 7 - 1 Pattern and other good practice when writing Sass.

  1

  

  Rabah•380

  @rabahmilanoPosted over 3 years ago

  @vanzasetia I really appreciate your help

  0