fylo landing page with two columns layout

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello MOHAMMED,

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • The logo's alternate text should not be empty. You can use the website's name as an alternate text. You may set alt=”Fylo".

  • Use <a> to wrap the list items. They supposed to navigate the user so they need an interactive element which is<a> . For example: <li class=".."><a href=”#” class=”...”>Features</a></li>.

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content. For decorative images, you set an empty alt to it with an aria-hidden=”true” to remove that element from the accessibility tree. This can improve the experience for assistive technology users by hiding purely decorative images like icon-phone, icon-arrow , icon-quotes and icon-email ...are decorative.

  • Forms with proper inputs and labels are much easier for people to use. To pair the label and input, one way is an explicit label’s for attribute value must match its input’s id value. Input fields without accompanying labels can lead to accessibility issues for those who rely on screen readers. If a screen reader comes across an input field without a label it will try to find some accompanying text to use as the label. (To hide the label visually but present for assistive technology, you may use sr-only class )

  • For the alternate text of the avatar testimonial should not be empty . You can use the avatar’s name alt=" kyle burton".

  • For the testimonial , you may use <blockquote>, <figure>, <figcaption>

  • Use the<nav > landmark to wrap the footer navigation with aria-label=”secondary “ or aria-label=”footer”. A brief description of the purpose of the navigation, omitting the term "navigation", as the screen reader will read both the role and the contents of the label. Thenav element in the header could use an aria-label="primary" or aria-label=”main” attribute on it. The reason for this is that, you should add the aria-label for a nav element if you are using the nav more than once on the page.you can read more in MDN

  • You may use the <address> tag to wrap the contact informationclass=”block” for the author/owner of a document or an article (email and phone number.)

  • If your icons are purely decorative, you'll need to manually add an aria-hidden attribute to each of your icons.

  • Instead of using a generic div to wrap the links , you put your links within an unordered list structure so that a screen reader will read out how many things are in the list to give visually impaired users the most information possible about the contents of the navigation.

  • The social links wrapping the icons must have aria-label or sr-only text indicate where the link will take the user. It might look like this:

  	      <ul class=”....” >
  	        <li><a href=”#” aria-label="Visit our facebook"> <i class="fa-brands fa-facebook " aria-hidden=”true”></i></a></li>
  	        <li><a href=”#” aria-label="Visit our twitter"> <i class="fa-brands fa-square-twitter" aria-hidden=”true”></i></a></li>
  	        <li><a href=”#” aria-label="Visit our instagram"> > <i class="fa-brands fa-square-instagram" aria-hidden=”true”></i></a></li>
  	      </li>
  	    </ul>
  
  

  You can have a look at my solution to this challenge, it might help Aside these , you did great work. Hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  mohammed abdo•220

  @Hazard-58Posted over 2 years ago

  @PhoenixDev22 Really thanks for this bro I really appreciate the feedbacks like this :)

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  @Hazard-58 Glad it was helpful. Happy coding!

  0