Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted about 2 years ago
Hey @Sphynxo, some suggestions to improve you code:
-
Nav menu do not have their hover effect.
-
The Illustrations serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.
-
For the testimonial, you want to wrapped it in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.
Code:
<figure> <blockquote></blockquote> <figcaption></figcaption> </figure>
More Info:
- The phone and email on the footer should be wrapped in Anchor Tags and set the href in the following manner so users can click on them and the phone/email app can open automatically:
Phone:
<a href="tel:+1-543-123-4567">Phone: +1-543-123-4567</a>
Email:
<a href="mailto:[email protected]">[email protected]</a>
Happy Coding! 👻🎃
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord