Responsive Landing page mainly working with Flexbox
Design comparison
Solution retrospective
i had some issues when i started the project mobile first responsive as i found some of the markup had to be changed when i started making it desktop responsive π.
I am proud however of pushing until the end and having the project look very similar.
also i used a regular jpg preview of the design without using FIGMA or SKETCH which was tricky decided what were the sizing and padding etc.. but overall very fun and exciting project to build. I definitely did not factor my CSS it can be a lot better but at least i was able to reach the end of the project π
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- The
header
element should only be wrapping the "logo" and βnav`.
- The βalt tag` description in the "logo" needs to be improved upon. The description should state the company name.
- The Illustrations serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=βtrueβ to hides it from assistive technology.
- Your headings are being used incorrectly. When it comes to using headings, you are not allowed to skip heading levels. so "Stay productive, wherever you are", "Get early access today" are suppose
h2
headings.
- Your
email input
andbutton
needs to be wrapped inside aform
and have a visibly hiddenlabel
attached to it for improved accessibility.
More Info:π
- For the testimonial, it is best to to wrap the testimonial component in a
figure
element, the individualβs information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <blockquote></blockquote> <figcaption></figcaption> </figure>
More Info:π
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!ππ
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord