Fylo landing page with two column layout

Community feedback

• 

  T

  Grace•31,690

  @grace-snowPosted almost 4 years ago

  Hi Chamu

  This looks really nice, good work 👍

  Only small things that may need looking at:

  • quite important for a logo to be announced with the name of the site, so fill in alt text on that
  • usually logo is a link to the homepage too, so maybe wrap in an anchor tag
  • see how fylo works link should probably be an anchor tag too, not button. Not sure why it's wrapping over 2 lines either(?)
  • id pop those footer uls inside nav elements (labelled)
  • don't forget about adding focus states
  • there's quite a few magic numbers in the css, but I'm not sure why. Eg width 88.9%; or 271px... I'm surprised you need anything like that when you can be using flex basis or grid minimax values for things. Keep an eye on that and see if you can avoid using them in future challenges.

  Hope thats helpful! You're doing really well with these now ☺

  1

  ---

  

  T

  Chamu•13,340

  @ChamuMutezvaPosted almost 4 years ago

  Thank you Grace - you raised some very important issues and will address them. Still to learn more on Flex and Grid - Indeed practice and more practise will make this sink.

  1