Design comparison
SolutionDesign
Solution retrospective
Que tal chicos aca mi solucion a este reto Frontendmentor, les agradecería criticas sobre la estructura y funcionalidad de mi código. Espero sus comentarios y muchas gracias.
Hi guys, thre is my solution for this Frontendmentor challenge, and i want to know what do you tihink about my code, structural and funcional. Thanks for all the coments and views!
Community feedback
- @ApplePieGiraffePosted about 4 years ago
Hey, Marcos! 👋
Good work on this challenge! Your solution is responsive! 👏
I suggest,
- Adding some padding to the sides of the page to give the content of the page some room.
- Turning the navigation links in the footer of the page into actual links with the anchor tag.
- Adding a hover state to the social media icons in the footer of the page would be a nice touch!
- The left and right sides of the hero section seem to be switched around in the desktop layout! Since you're using CSS grid, though, that shouldn't be too hard to change with the
grid-columnandgrid-rowproperties. - Don't forget to make your form accessible! 😉
Keep coding (and happy coding, too)! 😁
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord