Fylo landing page with two column layout

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The ‘alt tag` description in the "logo" needs to be improved upon. The description should state the company name.

  • There needs to be a nav element wrapping your navigation menu.

  • The “illustrations” serve no other purpose than to** be decorative**; They add no value. Their alt tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • Your headings are being used incorrectly. "All your files in one secure location, accessible anywhere" should be an h1 heading. While "Stay productive, wherever you are" and "Get early access today" are h2 headings.

  • Your email input needs to have a label attached to it to improve accessibility.

  • The company info inside the footer needs to be wrapped inside an address element. While each individual information needs to wrapped in an anchor element.

  • The company "directory" needs to wrapped in a nav element and be a single list, not two. You will use the CSS property column to style it.

  • Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.

  Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.

  https://www.joshwcomeau.com/css/custom-css-reset/

  https://meyerweb.com/eric/tools/css/reset/

  http://html5doctor.com/html-5-reset-stylesheet/

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  1

  ---

  

  Wadie Ben•200

  @WadieBenabdouhPosted almost 2 years ago

  @vcarames First of all thank you so much for the feedback, I will absolutely make sure to apply every single advice you pointed here, also thanks for the resources, your help is greatly appreciated.

  Happy coding and happy holidays my friend.

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @WadieBenabdouh

  Glad I could help!☃️

  Do not forgot to check your FEM report, to see what is incorrect and update your code with it before moving on to the next challenge.

  Keep it up!

  Marked as helpful

  1