Fylo landing page with two column layout

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Carl Eder P. Ballenas,

  Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:

  HTML

  • If you are going to leave the logo not wrapped by <a>, it’s better to place it out the <nav> as it does not navigate the user in anywhere(only an image).

  • Forms with proper inputs and labels are much easier for people to use. To pair the label and input, one way is an explicit label’s for attribute value must match its input’s id value. Input fields without accompanying labels can lead to accessibility issues for those who rely on screen readers. If a screen reader comes across an input field without a label it will try to find some accompanying text to use as the label. (To hide the label visually but present for assistive technology, you may use sr-only class ).

  • look up a bit more about how and when to write alternate text on images. Learn the differences between decorative/meaningless images vs important content . For decorative images, you set an empty alt to it with an aria-hidden=”true” to remove that element from the accessibility tree. This can improve the experience for assistive technology users by hiding purely decorative images.

  • Profile images like that avatar are valuable content images, not decorative .For the alternate text of the avatar testimonial should not be avatar-testimonial. You can use the avatar’s name alt=" kyle burton".

  • You may use like to use <address> tag to wrap the contact information class="contact" for the author/owner of a document or an article (email and phone number). By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • When you use the<nav > landmark to wrap the footer navigation instead of <article> , you should add aria-label=”secondary “ or aria-label=”footer” to it . A brief description of the purpose of the navigation, omitting the term "navigation", as the screen reader will read both the role and the contents of the label. Thenav element in the header could use an aria-label="primary" or aria-label=”main” attribute on it. The reason for this is that, you should add the aria-label for a nav element if you are using the nav more than once on the page.You can read more in MDN

  • Links must have discernible text. The social links wrapping the icons must have aria-label or sr-only text indicate where the link will take the user. Your icons are purely decorative, you'll need to manually add an aria-hidden attribute to each of your icons.

  Aside these, you did great work. Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Carl Eder P. Ballenas•290

  @CarlTheBeginnerPosted about 2 years ago

  @PhoenixDev22 I applied what you said about aria-label it worked! I have no accessibility issues. Thank you! check the website repo on my Github.

  0
• 

  Ilesanmi Emmanuel•110

  @IlesanmieaPosted about 2 years ago

  Carl, I am amazed with your works. I took my time to review your code. I liked the way you wrote the codes, the custom CSS, the way you commented your codes, the way you analyze everything.

  Cudos and God bless you. Keep improving

  0