Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
👾 Hey there! 👋 Here are some suggestions to help improve your code: 👾
Best practice, before moving on to the next challenge, always check your FEM report, to see what is incorrect and update your code with it so that you would not make the same mistake over again. This something that should be done right after submitting your challenge.
- The
alt tag
description in the logo needs to be improved upon. The description should state the company’s name.
- Your
email input
needs to have a visibly hiddenlabel
to improve accessibility.
More Info:📚
- For the testimonial, it is best to to wrap the testimonial component in a
figure
element, the individual’s information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <blockquote></blockquote> <figcaption></figcaption> </figure>
More Info:📚
- The company info inside the
footer
needs to be wrapped inside anaddress
element. While each individual information needs to wrapped in ananchor
element.
More Info:📚
- The company directory needs to wrapped in a
nav
element and be a single list, not two. You will use the CSS propertycolumn
to style it.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord