Fylo landing page with two column layout

Community feedback

• 

  Bonrey•1,130

  @BonreyPosted over 3 years ago

  Hi, @soransh-singh! 🙋‍♂️

  Good job on this challenge! Here are a few suggestions I can offer:

  • Add some padding to your header so that it doesn't stick to the top of the screen. It would look much better, I promise! 😁

  • It'd also be nice to set some border-radius for buttons and input fields. This way, they would look less jagged.

  • To fix your accessibility issues, I suggest adding aria-label with some text to both of your inputs. Also, it's not a best practice to add an empty name property to the buttons (<input type='submit'>). You can safely delete it, I presume.

  P.S. It's great to see that you're completing so many challenges on Frontend Mentor! Keep up the good work, and good luck with your coding! 🍀

  1

  ---

  

  soransh singh•1,025

  @soransh-singhPosted over 3 years ago

  @Bonrey hey, thanks for the feedback, yupp adding some padding and border-radius will make it look far better. and I was never able to resolve accessibility issue , thanks for the suggestion.

  1

  

  Bonrey•1,130

  @BonreyPosted over 3 years ago

  @soransh-singh no problem. Glad to be of some help 😊

  0