Html and Css

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code: 👾

  • Best practice, before moving on to the next challenge, always check your FEM report, to see what is incorrect and update your code with it so that you would not make the same mistake over again. This something that should be done right after submitting your challenge.

  • The nav element needs to wrapped inside a header element.

  • The ‘alt tag` description in the "logo" needs to be improved upon. The description should state the company name.

  • The "All your files in one secure location, accessible anywhere" should be an h1 heading.

  • Your email inputs should have a visibly hidden label to improve accessibility.

  • For the testimonial, it is best to to wrap the testimonial component in a figure element, the individual’s information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
  	<blockquote></blockquote>
   	<figcaption></figcaption>
  </figure>
  

  More Info:📚

  MDN Figure Element

  • The company info inside the footer needs to be wrapped inside an address element. While each individual information needs to wrapped in an anchor element.

  More Info:📚

  MDN Address Element

  • The company directory needs to wrapped in a nav element and be a single list, not two. You will use the CSS property column to style it.

  More Info:📚

  MDN <ul>: The Unordered List element

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-sizeand other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  0