Fylo landing page with two column layout

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi Luca, I think you did a great job on the whole with the responsiveness! One thing I'd change is at around the 800px breakpoint when the flex direction chanages, and the text in the sections with an image looks all pushed to the left side. I'd probably change the size of the images to make things a bit more evened out by using responsive widths instead of fixed ones

  The main suggestion I have is not related to responsiveness but to the HTML structure and tags. I see that you have the content and hero image all put under the header element. I would actually only have the logo and nav there, and I'd have the text and image in a section instead. You also need to fix the issues in your report, like having two footer tags and not having a main landmark. You can just add a <main></main> after the closing </header> and then put all the content into the main.

  Keep going! 🙂

  Marked as helpful

  1