Design comparison
Community feedback
- @ArigatouzPosted about 4 years ago
wow really awesome work there keep it up Imali Esiera just a hint : the social media icons need to have an indicator that it is clickable you can put it in the anchor tag or use the property cursor: pointer in CSS also the part of the ((kyle burton )) I can see in the original it has shadow so you can use on the main div which contains all the parts (( pic, etc...) you can also use box-shadow : 5px 5px 10px rgba(0,0,0,0.6); again the design is total awesome thank you for sharing it
0@imaliesieraPosted about 4 years ago@Arigatouz Thank you so much for the feedback. I also later realised that the social media icons are un-clickable. I will implement the corrections. I additionally had a problem with my body height. It doesn't look exactly like the solution. Might you know what the problem is?
0@ArigatouzPosted about 4 years agoI took a look at your code and the problem is that u never gave the specific font size to any of the heading nor the body text I will give you the heading font size and the text font-size I add and it looked a bit nice heading will be 40px and text will be 17 px for your first wrap and text will be 16 px in the second wrap also, the text in the card will be 13px and the name of the guy will be 12 px and the text down the name of the guy will be 8 -10 see which one fits better as for the third part or you named it third-third-wrap the heading will have something around 29 to 37 px choose whatever fits more and make the body text of this part may be around 17px or so Of course this is all for the DESKTOP version which is at 1440px wide as for phone you get the idea you can fix it by shrinking fonts down :D
0@ArigatouzPosted about 4 years agohope i did help you and one more thing in the second wrap the image is repeated to many times this is all small changes but makes a huge difference hope I've been a help for you and keep on coding more and more, well done :D
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord