Fylo landing page with two column layout

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 5 years ago

  Hey Lucas, your site looks great! Quick heads up that your repo link currently navigates to the wrong GitHub repository though 👍

  Here are a few things I've seen from looking at your code:

  • You're currently using lots of div elements for your HTML structure. I'd recommend swapping out some of those for semantic HTML5 elements like header, footer, section, main. If you would like to read up on HTML5 elements, here is a great article from freeCodeCamp.

  • You're using more than one h1 on the page, which I'd recommend against doing for accessibility and general content hierarchy reasons.

  • For the curved edge on the testimonial section you're using the img tag. Because this is for purely decorative reasons I would recommend using the background-image property in CSS instead so that it is not adding content to the HTML unnecessarily.

  • Great work on the CSS, the page looks great!

  Hope those tips help and keep up the great work! 🙂

  2

  ---

  

  gomezlucas•1,115

  @gomezlucasPosted over 5 years ago

  Thanks Matt! Very useful your advice. I'll definitely do it that way in my next challenge and I'll change this code later as well.

  0