Design comparison
Solution retrospective
feedbacks please
Community feedback
- @pikapikamartPosted over 3 years ago
Hey, great work on this one. In terms of layout, the desktop is fine, just some tweaking of padding will be awesome. The mobile is good and no issues when resizing the layout.
Suggestions would be that:
-
You navbar links should be wrapped inside
a
tags. Right now, they are just inside ofli
which doesn't do anything. Inside thatli
wrapped the text inside their respectivea
tags. We need to make our markup clean and semantic. -
Font sizes should be adjusted as well, since there are sections where the font-size are really small. Like the testimonial the text are small and hard to read. Tweaking those will be really good and the testimonial itself, the background-color is different, as well the whole section. You forgot to change the background-color of it. Though I think you did not include it, since if you include it, it will overlap the curve image right. That curved image could just been inside
::before
or::after
, that way you can copy like the original. -
Footer links should be as well wrapped inside their
a
tags. Remember to put all supposed links, insidea
tags, including the social media icons.
But still, great job on this^
0@IsenrafPosted over 3 years agoHi @pikamart thanks for the great feedback I completly forgot that i had to do things in a semantic and clean markup(will fix this as well). Thanks again
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord