Design comparison
Solution retrospective
Hi there, feel free to leave any feedback and help me to improve my solution.
Community feedback
- @MelvinAguilarPosted about 1 year ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- In your design, the links in the footer and header should be wrapped inside an unordered list (
<ul>
) and then contained within a<nav>
element. This provides a clear semantic structure and helps screen readers understand the navigation.
-
The
aria-hidden="true"
attribute is used to hide an element from accessibility tools like screen readers. However, using it alongside an alt attribute can create confusion, as alt provides accessibility information while aria-hidden tries to hide the element. This combination may lead to contradictory behavior for assistive technologies.In the case of logos and images within div.user for testimonials, you generally don't want to use
aria-hidden="true"
because these are typically meaningful content that should be accessible to all users, including those using screen readers.
I hope you find it useful! ๐
Happy coding!
Marked as helpful1@Amens11Posted about 1 year agoHi @MelvinAguilar, thanks for your useful suggestion. I will update my code based on your comments.
1 - In your design, the links in the footer and header should be wrapped inside an unordered list (
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord