Fylo landing page with two column layout

Community feedback

• 

  David Ouma•270

  @daudi13Posted almost 4 years ago

  Hello Karim, thank you for your submission I really think you did a good job on the project . I can see your project is very responsive for both Mobile and desktop display. I just have a few comments on your code.

  1. I noticed you didn't use a div eg .container to wrap your code after the body.

  2. You didn't use header nav or footer to group your markup. remember you can create a website using HTML alone but you can't create a website without it. So your markup needs to be understood by the search engines.

  3. You did use button instead of button:submit for your buttons.

  4. You didn't add any border-radius for your buttons.

  5. You didn't use the suggested font-size, font-family and font-weights that came with the README.md file.

  6. Try learning BEM naming convention for naming divs in your HTML.

  In general I think you really tried your best. keep being consistent and you'll see the results. Keep up the good work. Happy coding. you can upvote a comment if you find it helpful

  1

  ---

  

  Karim•810

  @Karimsamir112Posted almost 4 years ago

  @daudi13 okay thanks you I understood

  0