Fylo landing page with theme toggle button

Community feedback

• 

  alexander•1,300

  @alex931dPosted 8 months ago

  Hello! Great solution! I decided to take a look at your newer solutions, but I noticed you didn't quite pick up from my last comment on your Loop webpage. So, again, I will state the issues:

  Why you should be using <ul> <li> <a> instead of <div> <a>:

  Using <ul> and <li> with <a> is semantically correct and provides a clear structure for lists of links. It enhances accessibility and SEO by conveying the proper meaning to browsers and assistive technologies. It also provides default markup if your CSS styles should fail to load, making it a far more superior choice. In contrast, using <div> with <a> may not provide the same level of clarity and could be considered less semantically sound.

  Why you should use a .gitignore:

  I have noticed in your GitHub repo that you still have your node_modules and package-lock.json. Normally, you would create a .gitignore to ignore those files since npm automatically creates them.

  Using FrontendMentor README in your GitHub repo:

  I noticed that you're not using the given FrontendMentor README file. I recommend you start doing it since it provides instructions about what your repo is.

  other then that great solution and you nail the design spot on!

  0