Fylo Landing Page with HTML and CSS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Abanum! 👋

  Congratulations on completing this challenge! 🎉 Good effort on this challenge! 👍

  I have a few suggestions for this solution.

  • Remove the <h1 class="sr-only">hide</h1>. What is the reason of adding it?
  • Alternative text for images should not contain any words that are related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). The semantic meaning of the img element is already good enough.
  • Move the lower-main-section inside to the main element. It's important for all page content to live inside the corresponding landmark element.
  • hidden attribute makes the label invisible to all users (including the users of assistive technologies). This is a good situation to use sr-only styling instead.
  • Always specify the type of the button. It's going to prevent the button from behaving unexpectedly.
  • The alternative text for the social media icons is all the same.

  I hope this helps!

  Marked as helpful

  1

  ---

  

  Abanum Oliseyenum•230

  @CodeyenumPosted over 2 years ago

  @vanzasetia thank you so much for your response, it’s really insightful and enlightening. I’ll go review it all now and try to apply your suggestions.

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @Codeyenum You're welcome! 👍

  Let me know if you have any questions. 🙂

  0