Design comparison
SolutionDesign
Solution retrospective
Feedback is appreciated :)
Community feedback
- @MojtabaMosaviPosted over 3 years ago
Hi good job on this one, here are a few things that you can improve.
-
Your fontsizes don't match the actual design, etheir use a tool like adobe xd to measure them or play around with different values in developer tools.
-
Consider using more sementic tags, like header, main and footer instead of divs. Use divs where there are no other suitable element.
-
For links use <a> instead of <h3>.
Happy coding :).
0@aabdulbassetPosted over 3 years ago@MojtabaMosavi Noted. Thank you for the feedback :)
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord