@vanzasetia
Posted
Hi, there! 👋
Nice work on this challenge! The HTML markup for the header is good, you don't include the first section inside the header. You have used landmark elements correctly, each landmark element wraps the appropriate page content. Good job! 👏
Anyway, some suggestions from me.
- I would recommend adding
aria-labelto thenavon theheader(the same as you did to thenavin thefooter). There are twonavelements on this page. So, I recommend adding a label to theheaderas well to help the users to distinguish bothnav. - The
quote-wrappersection should not have a heading tag. It's actually the part of the previous content. - For the
olelement that wraps the social media links. I think it's better to useulinstead. It's becauseolis an ordered list which means it's better to use it for step-by-step content. What do you think about this? - Lastly, I recommend fixing all the issues that have been reported.
I hope this helps! Keep up the good work! 👍
Marked as helpful
@vanzasetia
Posted
@alwaysBeThankful Next time, I recommend asking for feedback whenever you are going to submit a solution. Even though you have no questions, it's best to ask for feedback.
You will never know that there's something that you can improve or learn from other people. 😉
@EuphoriaCXI
Posted
@vanzasetia Thank you very much for your time Vanza! I appreciate your time. Would you say after these improvements you've mentioned I'm ready to start JavaScript?
@vanzasetia
Posted
@alwaysBeThankful I think you need to do more HTML and CSS challenges while you are learning JavaScript. I still notice some areas that can be improved such as,
- On
840pxthe input form is very wide and almost all the text become one line. The wrapper elements should have differentmax-width(not only1440px. - Add
:focus-visiblestyling to all interactive elements. This will let people who use a keyboard to navigate the site know where they are currently on the page.
So, I would say keep sharpening your HTML and CSS skill by doing Frontend Mentor challenges while learning JavaScript. 🙂
Marked as helpful
@EuphoriaCXI
Posted
@vanzasetia Thanks Vanza, I'll keep doing the HTML and CSS challenges while learning JavaScript. I've actually just posted and completed another CSS challenge lol.
