Fylo Landing Page - HTML CSS

Community feedback

• 

  Jonathan Koh•310

  @JonKohJJPosted over 3 years ago

  Hi Pikamart! Thanks for the feedback. I have done the necessary changes but I still needed to cut a few corners. Regarding the 'width: 100vw' attribute on my 'filler' div, may I know what phone you are using? I am not able to horizontally scroll on my iphone 8 plus.

  0
• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, great work on this one. Though I zoomed out because layout is for mobile, are you using large screen? Though the layout is good both in desktop and mobile.

  Some suggestions would be:

  1. On the navbar links also in the footer links, you are transitioning the font-weight right, this makes a shake and pushes other elements. Instead what you can do, is transition text-shadow giving an effect that the text are getting bolder by adding it to the text. This way, it won't create that pushing effect.

  2. Adjusting your breakpoints, I saw that you added 1440 something as a tablet size. There are lot of users, like me, using 1366x768 monitor/laptop. So I will always get that tablet size and need to zoom out. Maybe considering lowering it down would be a great idea.

  3. Your "see how fylo works" should have been wrapped inside a tag, since it is supposed to be a link.

  4. Your email input as well as the button next to it should have been inside a form tag. Also add a name property on the input, this is the targeting property whenever other developer who is on backend will use to get the data need from the form.

  5. On the mobile view, there is a horizontal scroll. To fix this, remove the width: 100vw on the filler selector inside your hero-container selector.

  Aside from those, really good job^

  0