Design comparison
Solution retrospective
Hi everyone! I'm a beginner, what do you think of my solution to this challenge? Any advice or feedback will be really appreciated. Thanks.
Community feedback
- @PleopleqPosted over 4 years ago
Goob job Peaky! One thing about your project is that the mobile version isnt the same as the challenge. You can experiment with "Mobile first desgin"
https://www.justinmind.com/blog/complete-guide-to-mobile-first-design/
Basically, you style the mobile version first an then scale everything from there. It work for me and i think (i think haha) is the standard.
2@peaky-qpPosted over 4 years ago@Pleopleq
Thank you so much for the feedback. I sincerely appreciate it and will use it for future improvement.
1 - @mattstuddertPosted over 4 years ago
Great work on this challenge! Your solution looks really good. Here are some pointers after taking a look at your code:
- You're using multiple
h1
elements at the moment. I'd recommend avoiding this as it can cause accessibility issues with the content hierarchy. Instead, I'd use a singleh1
and then the other heading levels to create a proper hierarchy. - For the heading levels, you're currently using
h1
andh5
but have no other levels. Try to avoid skipping heading levels unnecessarily as this can also cause accessibility issues. - Your media query is currently set to
max-width: 375px
. This means that at376px
upwards it looks very squashed until the screen gets to roughly a large tablet size. Always be sure to review the layout of your site across a wide range of screen sizes. It's a tricky part of front-end web development but it's a skill well-worth learning and refining.
Let me know if you have any questions. Keep up the great work! 🙂
1@peaky-qpPosted over 4 years ago@mattstuddert
Thank you so much for the feedback. I will try to improve the solution following your advice!
0 - You're using multiple
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord