Fylo Landing Page - Basic HTML and CSS

Community feedback

• 

  Felix Anducho•400

  @PleopleqPosted almost 5 years ago

  Goob job Peaky! One thing about your project is that the mobile version isnt the same as the challenge. You can experiment with "Mobile first desgin"

  https://www.justinmind.com/blog/complete-guide-to-mobile-first-design/

  Basically, you style the mobile version first an then scale everything from there. It work for me and i think (i think haha) is the standard.

  2

  ---

  

  peaky-qp•130

  @peaky-qpPosted almost 5 years ago

  @Pleopleq

  Thank you so much for the feedback. I sincerely appreciate it and will use it for future improvement.

  1
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Great work on this challenge! Your solution looks really good. Here are some pointers after taking a look at your code:

  • You're using multiple h1 elements at the moment. I'd recommend avoiding this as it can cause accessibility issues with the content hierarchy. Instead, I'd use a single h1 and then the other heading levels to create a proper hierarchy.
  • For the heading levels, you're currently using h1 and h5 but have no other levels. Try to avoid skipping heading levels unnecessarily as this can also cause accessibility issues.
  • Your media query is currently set to max-width: 375px. This means that at 376px upwards it looks very squashed until the screen gets to roughly a large tablet size. Always be sure to review the layout of your site across a wide range of screen sizes. It's a tricky part of front-end web development but it's a skill well-worth learning and refining.

  Let me know if you have any questions. Keep up the great work! 🙂

  1

  ---

  

  peaky-qp•130

  @peaky-qpPosted almost 5 years ago

  @mattstuddert

  Thank you so much for the feedback. I will try to improve the solution following your advice!

  0