Fylo landing page.

Community feedback

• 

  Simeon Udoh•535

  @simeon4realPosted almost 5 years ago

  Hello @pleopleq, Congrats on your submission. Just saw you know, I had a hard time completing the Fylo dark theme challenge as well. I used CSS Grid for the Desktop version but didn't know how to make it responsive so on Mobile, I switched the display to flexbox 😁

  I have a couple of recommendations though:

  1. Wrap your input forms using the <label></label> element. Here's an example :

  <label> <input type="email" name="name" >
  </label>
  

  2. Add arial-label to your input forms. It helps with accessibility which is continuously growing on the web. Eg: <input type="email" **aria-label="email address"** >

  3. Learn BEM Methodology:https://www.smashingmagazine.com/2018/06/bem-for-beginners/

  4. Decrease the font size on smaller screens.

  You can upvote my feedback if you found it useful.

  2
• 

  Patrick Touchette•355

  @patricktouchettePosted almost 5 years ago

  I also take ages to complete these challenges. I look at the design and think, EASY, i'll be done in an hour...Then 6 hours later still not done haha.

  Your css and images did not load properly due incorrect file paths. You can use ./ (current directory) instead of / (root directory).

  In your index.html replace this:

  <link rel="stylesheet" href="/styles/styles.css">

  with this:

  <link rel="stylesheet" href="./styles/styles.css">

  Same thing for the images.

  for more info check this out. https://stackoverflow.com/questions/7591240/what-does-dot-slash-refer-to-in-terms-of-an-html-file-path-location

  cheers!

  2

  ---

  

  Felix Anducho•400

  @PleopleqPosted almost 5 years ago

  @patricktouchette Apparently i always get the same problem haha thanks!

  0
• 

  Felix Anducho•400

  @PleopleqPosted almost 5 years ago

  Wow, thanks for all the good tips! yeah, i would say this is my worst project and i was thinking to just not finish it. But the good thing is that i didnt leave it, and i learn a lot and your feedback gives me more things to learn. Thanks again!

  0