Design comparison
SolutionDesign
Solution retrospective
Hi!
I wanted to spend some time practicing CSS layouts. If you have any ideas on how I could have improved my code, especially CSS, let me know! Also, I am still getting the hang of all the units in CSS. If you have any tips or improvements, please let me know
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
- For example:
- The
<main>
element should include all content directly related to the page's main idea, so there should only be one per page - The
<footer>
typically contains information about the author of the section, copyright data or links to related documents.
- But you have used
main
for a single block and then continued withsection
elements actually those every content want to be nested inside themain
element
section
element can't define the landmark of an site, it's semantic though but it's only used within landmark elements likemain
- So resolve the issue by wrapping all those elements except
header
&footer
with the proper semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@GamuchiraiSPosted over 1 year ago@0xAbdulKhalid Thank you for the recommendations. I'll apply them now
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord