Design comparison
Solution retrospective
Hey any feedbacks would be great. I assumed the max height was 800px based on the design.
Community feedback
- @krisp-devPosted over 3 years ago
Overall looks good but noticed 2 small issues;
-Your bg-desktop.png on widths higher than 1440px is losing its position. I think you should put this on the 'body' rather than your container since your container has a height of 800px. When I did this challenge I set the 'background-position: bottom' and 'background-size: 100vw 50vh'
-The progress bar on mobile seems to be 100% filled up.
Marked as helpful1@promathieuthiryPosted about 3 years ago@krisp-dev thanks a lot for your reply ;). Indeed I didn't know how to make the background responsive. I did what you told me and it worked. Yes I forgot about the progress bar on mobile. To make responsive on mobile, I used percentage instead of a number of pixels.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord