Fylo data storage with SASS

Community feedback

• 

  Kris Pietrzak•340

  @krisp-devPosted over 3 years ago

  Overall looks good but noticed 2 small issues;

  -Your bg-desktop.png on widths higher than 1440px is losing its position. I think you should put this on the 'body' rather than your container since your container has a height of 800px. When I did this challenge I set the 'background-position: bottom' and 'background-size: 100vw 50vh'

  -The progress bar on mobile seems to be 100% filled up.

  Marked as helpful

  1

  ---

  

  Mathieu THIRY•300

  @promathieuthiryPosted over 3 years ago

  @krisp-dev thanks a lot for your reply ;). Indeed I didn't know how to make the background responsive. I did what you told me and it worked. Yes I forgot about the progress bar on mobile. To make responsive on mobile, I used percentage instead of a number of pixels.

  0