Fylo data storage white bootstrap & Sass

Community feedback

• 

  Amir Jacobs•165

  @Amir-JacobsPosted almost 4 years ago

  I love your usage of variables in CSS. I also like that you've used prefixes where needed.

  Some things I'd do differently are:

  • Change width: x% to width: 100%; max-width: x%, as this helps with responsive design.
  • I'd limit the amount of classes I put on the html elements, because it becomes harder to read otherwise (though I understand that with bootstrap it's inevitable to add classes). I'd look into the BEM method.
  • I noticed you need to use margin-top: -340px; margin-right: -340px; on a class, which points to an issue in a part of the CSS.

  Overall it looks clean and structured. :)

  2

  ---

  

  AngelARVM•175

  @AngelARVMPosted almost 4 years ago

  Hi Amir, I really appreciate your comments.

  I had take a look into the BEM method and i'll try to apply it. And I promise I tried to use absolute positions with the left storage speech bubble, but somehow a lot of things broke. I think I should go over these concepts.

  Anyway thank you so much :)

  0