Fylo data storage component solution

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello! Awesome job with this one. You did a great job and to improve the code structure, I would suggest the following:

  • Add height: 100vh on the body tag to make the whole content align in the center
  • Adjust the position of the background into background-position: 2rem 230px; or something.
  • Add a padding to the .attribution rule set to put a distance between the content
  • Add a value of the padding in the .container .main rule set, you should not leave it empty
  • For the footer, instead of div change it into footer tag to make it more readable
  • It is common to use div to wrap the .container but for best practices, using main tag is advisable for accessibility.

  Overall you did well and keep going!

  0

  ---

  

  Abdullah Al-Karim Amrullah•400

  @alkarim99Posted almost 3 years ago

  @RioCantre thank you for the advice given, it means a lot to me who wants to hone my frontend skills, I will try it

  0