Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Fylo data storage component - SCSS

@ParaPaca

Desktop design screenshot for the Fylo data storage component coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


  • What do you think are the best practices for this project?
  • What am I supposed to do to improve my code?

Thanks in advance for your feedback 😊

Community feedback

@Blackpachamame

Posted

I could only rate your solution as perfect 😎

It looks super correct and the animations give it an extra plus.

I can only add:

  • You defined the same thing twice in the body, height: 100vh and height: 100dvh, technically they are not the same, but they are overwritten because the property is the same (CSS will apply the one below)
  • You could set the alt attributes as empty, for accessibility reasons, not leaving just alt but instead setting alt="". This is to improve accessibility, as in this case the images are only decorative, the description is left empty. More info
  • You could remove comments that are not useful in your HTML

Marked as helpful

2

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord