Design comparison
Solution retrospective
Hello, everyone! I just finished this challenge. It was fun and I learned a lot. I used positioning instead of grid to place the divs -- feels like I'm doing it the "stupid" way, especially the way I create the triangle in the desktop version and the progress bar. Please leave me a comment on how I can improve and do things more efficiently. Thank you so much for your time!
Community feedback
- @romila2003Posted about 2 years ago
Hi Charmonder,
Congratulations 🎉 for completing this challenge, the component looks great. It is great that you used the flex property to center the card. I have some suggestions I want to address:
- I would suggest giving the
background-color
property to the body instead of.container
as you can see the background color shifts with the container, as you decrease the screen size. Also, it looks like you are treating themain
tag as the body which is not how to use it. The container should contain the code, in this case it will be the 2 cards/components therefore theflex
property should also be assigned to the body too. - Another way you can create the triangle, is through using the pseudo
::after
property which will allow you to add the triangle after the box. If you are unsure about this concept, you can research more about it and can also check mine out to see how I did it which is here: Fylo data storage component
Overall, great attempt and wish you the best for your future projects 👍.
Marked as helpful1 - I would suggest giving the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord