Fylo data storage component / HTML & Sass

Community feedback

• 

  Roman Filenko•3,335

  @rfilenkoPosted about 4 years ago

  Hey there, great job. You can use variables in scss as well, also nesting is usefull (specialy for writing pseude elements or classes). Try to be more consistent with values (margin, padding, font-sizes, like you coded 2px, 5px, 7px, 81.5%). On bigger projects - split scss into multiple files with imports is common practice. Keep it going😉

  Best, Roman

  1

  ---

  

  Hortense From•20

  @HortensefromPosted about 4 years ago

  @rfilenko Hi, thanks for the feedback ! I was also wondering about consistency so that really helps, I'll keep that in mind for my next challenge. 😊

  0
• 

  Hari Ram•370

  @hariramjp777Posted about 4 years ago

  Hi @Hortensefrom, Great job, I recommend using a separate div for background and scss variables, imports.

  You can refer my solution, https://github.com/hariramjp777/frontend-fylo-data-storage-component/

  Great work, keep it up :thumbsup:

  0

  ---

  

  Hortense From•20

  @HortensefromPosted about 4 years ago

  @hariramjp777 Hi, thank you for your feedback ! I'll take a look at your solution, that'll help. 😊

  0