Design comparison
Solution retrospective
all feedback are welcome :)
Community feedback
- @RahulbaranPosted almost 2 years ago
Hi, I am Rahul. I went through your code and here are the things I found:-
By default, a browser applies some paddings and margins which makes it tough to place the items properly, You can resolve this by setting margin and padding to zero in universal selector.
Progress bar is not positioned correctly,
Use "rem" or "em" instead of "px" for font-size, padding & margin
background image for desktop version is not positioned correctly
Marked as helpful0@tifflee7784Posted almost 2 years ago@Rahulbaran
Hi Rahul. Setting padding and margin to 0 in universal is useful tip. I should do it in every project. I will revise the background and progress bar position soon.
Thanks for the feedback :)
0@RahulbaranPosted almost 2 years ago@tifflee7784
I am very glad to help you. Have a great day😊
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord