Fylo data storage component

Community feedback

• 

  Ahmed Kamel•1,190

  @hmadamkPosted about 2 years ago

  • well done looks perfect a couple of notes though

  • remember to reset your body like so

  body{
    margin:0;
    min-height:100vh;
  }
  

  this will make you background stretch with the page and prevent any scroll which is very beautiful

  • make sure that all of your page is contained by a landmark examples of landmarks are

  header for the top section
  main for your main section
  section with aria-label to describe why you added this section
  footer for the bottom section
  
  

  in this solution you are using a single section so wrap it inside of a main what this does is that it helps assistive technology to help people consume your websites better

  • you should use heading in order so h1 > h2 >h3 etc and manipulate the font size later as you want remember that the headings indicate section of your app so the page is a section and should have a name inside of h1 the card is a subsection and should have a name inside of an h2 and so on remember heading indicate the level of this section not for big font and all your landmarks must have an h2 level heading and any nested section will take h3 then h4 and so on

  Marked as helpful

  0

  ---

  

  kath•130

  @KathundPosted about 2 years ago

  @hmadamk with making landmarks

  I have never used landmarks much I have always used a div with the class contrainer but I made a script to where if I made a div using class container it just dosent work. like it would just remove it. basically trying to force my self into using them. this script was started because of your comment so thank you

  0
• 

  Harsh Kumar•1,390

  @thisisharsh7Posted about 2 years ago

  Hello Kath, well done! your solution looks nice.

  To answer your query, creating that shape, takes mine time too but there is nothing to worry about You need to learn some basic concept of polygon in CSS and there are several website which help you in making different polygon shapes. Here are some links to help you

  1. For making different polygon shapes :- shapes online
  2. For learning about polygon in CSS :- CSS shapes

  hope this helps you, happy coding✌️.

  1