Design comparison
Solution retrospective
Hi guys. This is my first time using rem and em instead of pixels. This is also my first time coding with a Mobile-First approach. If there are any improvements to the code I will be more than happy to receive your feedback.
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Diaa Faris, how are you?
Congratulations for completing another challenge, I really liked the result of your challenge, but I have some tips that I think you will like:
1- Page should contain a level-one heading click here
I noticed that the background image is covering the entire screen at higher resolutions, to fix this we can do the following:
@media (min-width: 54.85rem) body { background-size: 100% 50vmin; }
It will have a height of 50% of the screen.
Hope it helps... 👍
The rest is great!!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord