Fylo dark theme with React and Sass

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Greetings, Sandro! 👋

  I just noticed that this is your 20th solution on Frontend Mentor. Great job! 🎉 I think you've done rather well on this challenge! 👏 Everything looks pretty great! 🙌

  There's just one or two minor issues on your solution report that you might want to take care of (looks like you might have to change a <div> to a <span> and add a heading somewhere). 🙂

  Well, keep coding (and happy coding, too)! 😁

  1

  ---

  

  Sandro•345

  @SanidethPosted over 3 years ago

  @ApplePieGiraffe Hey there, Thank you very much!

  Unfortunately this design doesn't have heading in that section and that's why report is screaming at me :P As for as the div inside the span, I fixed that but forgot to generate new report :P

  Thank you!

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @Sanideth

  Haha, okay, no problem! 🙂

  For sections of a page that don't have a visual heading, I think you can still add a heading but add a visually-hidden class to it so that it doesn't affect the layout and won't be seen but will still be there for screen readers and to improve SEO and/or accessibility and stuff. Just a tip! 😉

  1

  

  Sandro•345

  @SanidethPosted over 3 years ago

  @ApplePieGiraffe Oh, didn't know that. Thank you!

  0
• 

  Marcin•570

  @FrontmaniaacPosted over 3 years ago

  Hello there :D Nice work on the project! You don't have to worry about the guidelines too much. You can always use Javascript or any framework you want. It's most important to acomplish the end effect of the website. Keep up the good work!

  1

  ---

  

  Sandro•345

  @SanidethPosted over 3 years ago

  @Frontmaniaac Hey there! Thank you for the feedback. I thought doing it with js would be much easier for me :P

  0