Design comparison
Solution retrospective
Looking for feedback! I hope the page is fully responsive.
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Daniel,
To solve accessibility issues:
-
<a> should have an aria-label ... [Click here to read more here (https://dequeuniversity.com/rules/axe/3.5/link-name)
-
Never left alt attribute empty in img tags Or add alt attribute in img tag, and add some meaning text in it, so that user able to understand.
Happy New Year ;)
Marked as helpful1 -
- @Sam-GulikerPosted almost 3 years ago
Hi Daniel,
I don't really have much to add to this comment ^^^^. But try to focus on spacing and paddings a bit more. It seems a bit off.
Happy coding.
1@dvenomb98Posted almost 3 years ago@Sam-Guliker yea i think its good idea to define padding and margin as variable :D thanks for reply
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord