Fylo Dark Theme Landing Page with HTML & CSS

Community feedback

• 

  Roman Filenko•3,335

  @rfilenkoPosted almost 4 years ago

  Hey, good job here, but I see a lot of small issues. To debug some of them use rule - * {outline: 1px solid orange;}. This will help to fix overflow problem. A few points for future projects:

  • don't set defined heigth on containers;
  • preferable don't use id's for styling;
  • img { max-width: 100%;} will make all images responsive;
  • it's better to set max-width on wrapping containers instead of just width.
  • use flexbox or css gris for layout, don't use position;
  • for spacing inside use padding.

  Try to fix some issues first, good luck😉

  Cheers, Roman

  2

  ---

  

  Philip•320

  @adedotxnPosted almost 4 years ago

  @rfilenko Thanks a lot, I'll get to fixing it right now :)

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Phyf3! 👋

  Good effort on this challenge! 👍

  To clear up some of the errors on your solution report, try to get rid of the duplicate ID's (and use classes for styling, as rfilenko suggested) and make sure to identify all of the <section> tags you use with a heading. Speaking of headings, I suggest going with what the solution report recommends and using a single <h1> tag for the page and less important heading tags for the rest of the headings.

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Philip•320

  @adedotxnPosted almost 4 years ago

  @ApplePieGiraffe thank youu, I'll do just that

  0
• 

  Philip•320

  @adedotxnPosted almost 4 years ago

  also i don't get why the design/solution comparison is displaying this way, looks better when you preview the site ;)

  0