Skip to content
Submitted over 3 years ago

Fylo dark theme landing page using HTML, CSS, JS

Lisa Clark•185
@Lisa-C-27
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Fylo dark theme landing page
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Once again I had difficulty with the background image - I ended up having to move it to a different section from mobile to tablet/desktop view to get it to sit right, which I feel this probably wasn't the best way to do this. All feedback welcome :)

Community feedback

  • Mojtaba Mosavi•3,760
    @MojtabaMosaviPosted over 3 years ago

    Look at the following things:

    1- Try to consistantly use relative units such as ems or rems because the give better performance when user adjusts their default font-size or zooms, I personally use em for media queries and rems for margin, padding and fontsizes.

    2- A alternative way to implement the footer would be to make the container a ul and each col an li.

    3- Regarding the background-images, you could also use pseudo elements to implement it.

    Keep coding :=)

    0
  • Tarek Hassan•50
    @Dodger23Posted over 3 years ago

    I have the same problem, I ended up putting the background in "before" of the header.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord