Fylo dark theme landing page using Grid, flexbox and vanilla css

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted almost 3 years ago

  Hey there,

  It's a great start to the challenge, doesn't look far off the design. I have a few thoughts to add though, where you could improve:

  1. Alt texts: this article is REALLY the ultimate guide to write alt texts, so I suggest you read it. But to sum up the issues you're having: alt texts have an important purpose: to describe the image and to help people who for some reason can't see them. For this, it's very important to have descriptive alt texts, without including words like icon, image, etc (using the img tag makes this obvious enough).

  2. For your nav links, you could use a ul instead of a div, as you have a list of items there. You're also missing hover states from these links.

  3. Your button in the "get started" section doesn't seem to be clickable. A cursor: pointer and a hover would look nice.

  4. Headings: they are part of the document's structure, so it's very important to use them correctly. You start by h1 (as you did correctly) and then you go in a descending order, one by one. To understand it better why this is so important, check out this video, Kevin Powell explains this very well by showing you good/bad examples.

  5. Your footer menu are supposed to be a list of links so here again, you should go by using ul and wrap an a inside each li.

  6. Your social media links don't show up (perhaps forgot to add your Font Awesome kit in the head?). Once you fixed this, you'd want to go with a ul and links inside again, with aria-labels describing where the links lead the user :)

  There are some other small issues here and there, but I think I gave you enough to think about already ^^ Overall I think you made a very good attempt here. I did this challenge myself and I remember it took me quite some time to get everything right. So good luck on improving on it and if you have any questions, ask :)

  Marked as helpful

  0