@elaineleung
Posted
Hi Trenton, congrats on your internship firstly, and great job in what you did for this solution. I think the image positioning looks good, and if the hero image is bigger and that's more spacing, that hero section can look closer to the original.
Anyway, I got two comments:
-
About the icon images, specifically the row with the "access-anywhere" and "security" icons: Right now because the security icon is slightly longer, the row looks a bit misaligned. I don't usually use
heightbut I think this is a case where I'd make all the icons have the same height to ensure all the text looks even if they're on the same row. -
For the "See how Fylo works" link, because it's stretched across the container, even the empty space beside the link is clickable. Then I had a closer look and saw that there's a huge left margin added on there, and it looks like those elements after the icons section are all positioned similarly. Have you tried using a separate section container here instead of kind of stacking them over the icons section, and then use flexbox for the image and the text area in this section? That way, when everything is in a container, you wouldn't need such huge margins, and it might be easier for positioning. In any case, for the link I mentioned, try reducing the width so that the empty space won't be clickable also.
That's it, and good luck with your internship as well with completing more projects! Hope to see more coming 😊
