Fylo Dark Theme Landing Page Solution

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hey, your solution looks great! The only thing I found a bit strange is getting that invalid email message when I simply hover over the button at the cta section. Apart from this, good job, I finished this one yesterday and I know it's not the easiest ^^

  Marked as helpful

  1

  ---

  

  Abdulrhman Kotb•395

  @abdo-kotbPosted about 3 years ago

  @FluffyKas Thanks for your comment!

  I've actually thought of different ways to display the error message properly without using JavaScript and this was the least weird way that came to my mind.

  1

  

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  @abdo-kotb Aaah I see! I didn't even know it's not javascript so I guess that's very good! :D It's not a major issue anyway!

  Marked as helpful

  1
• 

  Kris Pietrzak•340

  @krisp-devPosted about 3 years ago

  Overall good job on this challenge! I have recently done this one myself and I found it quite challenging.

  I have found 2 minor issues; the svg element in your hero section ::before is not stretching the entire width of the screen and looks cut off at the edges (for example on 1920px screen).

  Another is, the headings and paragraphs in your feature section are misaligned due to the svg elements having mixed heights, and adding a margin-bottom to the svg icon itself will cause the misalignment. The way I approached this was to wrap the img element in a div and set the max-height of the div to 88px - which is the height of the security icon which is the biggest one of them all, and then vertically align the icons in their respective divs.

  Great job though, looks solid!

  Marked as helpful

  1

  ---

  

  Abdulrhman Kotb•395

  @abdo-kotbPosted about 3 years ago

  @krisp-dev Thanks for your comment and suggestions. I really appreciate it.

  I actually spent a lot of time focusing on the smaller screens' widths that I forgot to check any width larger than 1440px 😄😄

  All the issues should be fixed now.

  Thanks again!

  0