Design comparison
Solution retrospective
I would like to know if there is a better way to change the svg icon color on hover
Community feedback
- @nelsonleonePosted almost 2 years ago
Hello, congrats on completing this challenge 🎉🎉 Here how to change the svg color on hover, hope it was helpful
make sure you used the
svg
in your html , notimg
In css you can target the svg fill / or the svg path fill (depends on where the color lays)svg:hover{ fill: red } svg:hover path{ fill:red }
Marked as helpful1@ahmedsaliuGitPosted almost 2 years ago@nelsonleone Thank you for your response, I would try it out.
0@ahmedsaliuGitPosted almost 2 years ago@nelsonleone I tried it with SVG hover and path it doesn't work, so keep inspecting all the descendant elements that can make it work, so I target
<use>
. And it works. thanks for the hint.0 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- For the testimonials, it is best ✅ to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <blockquote></blockquote> <figcaption></figcaption> </figure>
More Info:📚
- ⚠️ The logo and company info inside the
footer
need to be wrapped inside anaddress
element. While each individual information needs to wrapped in ananchor
element.
More Info:📚
- ⚠️ The company directory needs to wrapped in a
nav
element and be built using theunordered list
element to create a single list. You will use the CSS propertycolumn
to style it. Each individual link needs to wrapped in ananchor
element.
More Info:📚
MDN <ul>: The Unordered List element
- Your
email input
andbutton
needs to be wrapped inside aform
⚠️ and have a visibly hiddenlabel
attached to it for improved accessibility 📈.
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
0 - For the testimonials, it is best ✅ to to wrap each individual testimonial component in a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord