Fylo dark theme landing page

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Unless if your company requires you to use a library , I strongly suggest you stay away from using libraries until you fully grasp the fundamentals of HTML, CSS and JS. By using a library, you are robbing yourself from actually learning how to code.

  • Do not forgot to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.

  • The logo and navigation menu should be wrapped inside a header element.

  • The alt tag description in the logo needs to be improved upon. The description should state the company’s name.

  • The navigation menu in the header should be wrapped inside a nav element.

  • "All your files in one secure location, accessible anywhere", "Access your files, anywhere", "Security you can trust", "Real-time collaboration", "Store any type of file", "Stay productive, wherever you are" and "Get early access today" are all headings, so they should wrapped in heading elements.

  • Along with the blank alt tag, you also want to include the aria-hidden=“true” to your Illustrations/icons to fully remove them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • To improve the semantics of your component, you want to wrap the testimonial component in a figure element, the author’s information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:📚

  ARTICLE

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0

  ---

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  • The company info inside the footer needs to be wrapped inside an address element. While each individual information needs to wrapped in an anchor element.

  More Info:📚

  MDN Address Element

  • The company directory needs to wrapped in a nav element and be a single list, not two. You will use the CSS property column to style it. Each individual link needs to wrapped in an anchor element.

  More Info:📚

  MDN <ul>: The Unordered List element

  • For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using these unit gives users the ability to scale elements up and down, relative to a set value.

  0