@VCarames
Posted
Hey there! π Here are some suggestions to help improve your code:
- Do not forgot to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
- The logo should be outside the
nav
and thefigure
is not needed since there is nofigcaption
attached to it.
- The "illustrations/icons" serve no other purpose than to be decorative. Their
alt tag
should left blank and have anaria-hidden=βtrueβ
to hide them from assistive technology.
More Info:π
https://www.w3.org/WAI/tutorials/images/
- Remove all the
article
elements you added, they are being used incorrectly.
- For the testimonials, it is best β
to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure>
<blockquote></blockquote>
<figcaption></figcaption>
</figure>
More Info:π
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! ππ
Marked as helpful
@VCarames
Posted
- The profile images
alt tags
need to be improved. It should state the following; βHeadshot of -personβs full name-β
More Info:π
- Your
email input
needs have a visibly hiddenlabel
attached to it for improved accessibility.
More Info:π
- The company info inside the
footer
needs to be wrapped inside anaddress
element.
More Info:π
- The company directory needs to be built using the
unordered list
element to create a single list. You will use the CSS propertycolumn
to style it.
More Info:π
Marked as helpful
@sanurb
Posted
@vcarames Hi π, Thank you very much for the feedback, I appreciate you taking the time to review it on your device. I will take care of it.