Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Fylo dark theme landing page using html, css sass #Mobile First

Davidβ€’ 200

@sanurb

Desktop design screenshot for the Fylo dark theme landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone πŸ‘‹, hope you all are doing well !

I've completed "Fylo dark theme landing page" challenge and I'm looking for advice or feedback

I ask if there is anything I can improve?

thanks ! πŸ˜„

Community feedback

@VCarames

Posted

Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

  • Do not forgot to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
  • The logo should be outside the nav and the figure is not needed since there is no figcaption attached to it.
  • The "illustrations/icons" serve no other purpose than to be decorative. Their alt tag should left blank and have an aria-hidden=β€œtrue” to hide them from assistive technology.

More Info:πŸ“š

https://www.w3.org/WAI/tutorials/images/

  • Remove all thearticle elements you added, they are being used incorrectly.
  • For the testimonials, it is best βœ… to to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

Code:

<figure>
   <blockquote></blockquote>
   <figcaption></figcaption>
</figure>

More Info:πŸ“š

MDN Figure Element

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! πŸŽ„πŸŽ

Marked as helpful

1

@VCarames

Posted

  • The profile images alt tags need to be improved. It should state the following; β€œHeadshot of -person’s full name-β€œ

More Info:πŸ“š

Headshot Alt Text

  • Your email input needs have a visibly hidden label attached to it for improved accessibility.

More Info:πŸ“š

MDN Email Input

  • The company info inside the footer needs to be wrapped inside an address element.

More Info:πŸ“š

MDN Address Element

  • The company directory needs to be built using theunordered list element to create a single list. You will use the CSS property column to style it.

More Info:πŸ“š

MDN <ul>: The Unordered List element

Marked as helpful

1
Davidβ€’ 200

@sanurb

Posted

@vcarames Hi πŸ‘‹, Thank you very much for the feedback, I appreciate you taking the time to review it on your device. I will take care of it.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord