Design comparison
Solution retrospective
Please feel free to give feedbacks
Community feedback
- @MishaHernandezPosted almost 4 years ago
Hi Karim, I have some observations for you:
-
I recommend not using <br> tags to generate spacing between elements, instead use margins, padding or spacing via flexbox or grid.
-
Use <buttons> tags instead of <div> and use the
font-size
property instead of header tags. -
In the action call (
.start1
) use a <form> tag as a container for the text box and the button. Use apadding
in the main container and use margins instead of <br>. -
In
.social-media
you use fontawesome icons but you must assign font css properties to give it size and color.
Finally I recommend that you review documentation about semantic html. Greetings and continue with the challenges :)
2 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord