[Fylo dark theme landing page challenge using html and css

Community feedback

• 

  Adriano•38,390

  @AdrianoEscarabotePosted about 2 years ago

  Hi Owokoniran Yusuf adebayo, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  The links must have an aria-label or sr-only text that tells where the link navigates the user. For example: Visit our Facebook. For images, you should set aria-hidden=” true” to be ignored by screen readers and to avoid redundancy and repetition.

  If we see how the layout is behaving at higher resolutions, with the help of google dev tools, we will see that it is stretching a lot, to solve this we can use a max-width with the value we want the content to stop growing and to center use a margin: 0 auto;

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  Owokoniran Yusuf adebayo•150

  @YusfuldevPosted about 2 years ago

  @AdrianoEscarabote Thank you so much for the feedback. It's really helpful, i will implement the changes.

  1

  

  Owokoniran Yusuf adebayo•150

  @YusfuldevPosted about 2 years ago

  @AdrianoEscarabote Thank you so much for the feedback. It's really helpful, i will implement the changes.

  0
• 

  KARTHIK•320

  @thekarthikrPosted about 2 years ago

  Hey Yusfuldev, I think you are talking about the Flyo logo image inside an anchor tag. It is an SVG image, you need to add a filter property to apply the hover effect

  svg:hover{ filter: invert(93%) sepia(8%) saturate(6609%) hue-rotate(121deg) brightness(104%) contrast(112%); } You can play around with fill property value inside the SVG code to change the color of the SVG image. Hope it helps.

  Marked as helpful

  1

  ---

  

  Owokoniran Yusuf adebayo•150

  @YusfuldevPosted about 2 years ago

  @thekarthikr thank you so much for your feedbback. I tried styling the fill just like I did with the social-media icons in the footer but it didn't work. However, i will apply filter method.

  0