Fylo dark theme landing page

Community feedback

• 

  Iuliia Konovalova•260

  @IuliiaKonovalovaPosted almost 3 years ago

  That's an amazing solution! Really! What I would add is to add some settings to the background image in <header> by adding background size: cover, and changing background-position to bottom center. In this case it will not go to the left size of the screen on the big desktop screens. And keep eye on the h1, h2, h3, h4 tags... You have to have only one <h1>, and the following should increase one by one. In you code you used <h2> and <h4> without <h3>. One more thing: add the following to the <a> links: rel="noopener" target="_blank" and aria-label="some text explaining what will happen if you click this link">

  1

  ---

  

  MD Salahuddin•150

  @mdsalahuddin2001Posted almost 3 years ago

  @IuliiaKonovalova Thank for your valuable suggestions

  0
• 

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted almost 3 years ago

  So to help with the accessibility issue remember to use only one H1 tag in your solutions it should be at the top.

  Also wrap everything in a semantic tag maybe a <main>

  1

  ---

  

  MD Salahuddin•150

  @mdsalahuddin2001Posted almost 3 years ago

  @Kamasah-Dickson Thanks for your helpful feedback

  0
• 

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted almost 3 years ago

  I think that's a very great solution there...nice and clean. can you share how you were able to add the dark background svg?

  Keep up with the good work:)

  1

  ---

  

  MD Salahuddin•150

  @mdsalahuddin2001Posted almost 3 years ago

  @Kamasah-Dickson You can get the source code from here - https://github.com/mdsalahuddin2001/frontendmentor-challanges/tree/main/fylo-dark-theme

  0