Fylo Dark Theme Landing Page

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 1 year ago

  Hi Bryan Li

  You have done well so far with the challenge , here are some items that you can attend to:

  • the image alt value is important when the image fails to load and for assistive technology users as well. Hence if the image is decorative , the alt value should be empty otherwise the value should be specific and not overly descriptive. Users should be able to get the message that is carried in the image.
  • your anchor elements are missing an important attribute, the href - I am not sure if that is intentional.
  • interactive elements should never be nested, in this case I am referring to the button and anchor elements. One must never be a parent of the other. We use an anchor element when we want to navigate to other sections or pages while a button is associated with click events such as a button to send a form or a button that toggles the menu item.
  • Heading elements should not be skipped, the first heading element of your site should be an h1 and for best practice , there should only be one heading element.
  • an input element should be associated with a label
  • the social icons are meant to be anchor elements to the associated social handles.
  • keep your styling simple, target the desired element(s) using classes. Avoid rules like the following .true-footer > .true-footer-contents > .true-footer-main-contents > .footer-socials-box div:hover . Such rules are difficult to maintain and debug.
  • the site is not responsive.

  0